Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styles of Gitalk & Gitment #568

Merged
merged 2 commits into from
Jan 6, 2019
Merged

Improve styles of Gitalk & Gitment #568

merged 2 commits into from
Jan 6, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved N/A
Gitalk, with scheme Gemini:
2019-01-05 11 56 51

Gitment:
2019-01-06 12 19 24
2019-01-06 12 19 32

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

Gitalk, with scheme Gemini:
2019-01-05 11 57 47

Gitment:

2019-01-06 12 21 12

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

{% if theme.vendors.gitalk_js %}
{% set gitalk_js_url = theme.vendors.gitalk_js %}
{% endif %}
<script src="{{ gitalk_js_url }}"></script>

{% set gitalk_css_url = '//cdn.jsdelivr.net/npm/gitalk@1.4.0/dist/gitalk.css' %}
{% set gitalk_css_url = '//cdn.jsdelivr.net/npm/gitalk@1/dist/gitalk.css' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if pull is ready, squash it.

@stevenjoezhang stevenjoezhang merged commit 36227af into theme-next:master Jan 6, 2019
ivan-nginx pushed a commit that referenced this pull request Jan 6, 2019
gitalk.css -> gitalk.min.css
@stevenjoezhang stevenjoezhang deleted the swig branch January 7, 2019 03:54
anthqiu pushed a commit to anthqiu/hexo-theme-next that referenced this pull request Aug 1, 2019
# By Mimi (4) and others
# Via Ivan.Nginx
* 'v6.x' of git@github.com:AntSYau/hexo-theme-next.git:
  add: details of configuration (theme-next#588)
  bugfix: make request time of leancloud saved and let concurrent requests pass (theme-next#519)
  Reorganize theme-next#576, using macro (theme-next#582)
  Edit Google Analytics reference file address (theme-next#580)
  Fix theme-next#573: [Muse & Mist] Footer is not at the bottom of the page (theme-next#574)
  Update Gitment URL to use jsDelivr CDN (theme-next#572)
  Fix theme-next#569 Valine Comment Count (theme-next#570)
  Improve styles of Gitalk & Gitment  (theme-next#568)
  Optimize the loading of comment systems (theme-next#566)

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
#	_config.yml
#	layout/_macro/post.swig
#	layout/_partials/comments.swig
#	layout/_partials/github-banner.swig
#	layout/_scripts/schemes/muse.swig
#	layout/_third-party/analytics/google-analytics.swig
#	layout/_third-party/comments/disqus.swig
#	layout/_third-party/comments/gitalk.swig
#	layout/_third-party/comments/gitment.swig
#	layout/_third-party/comments/index.swig
#	layout/_third-party/comments/valine.swig
#	layout/_third-party/copy-code.swig
#	source/css/_common/components/header/github-banner.styl
#	source/css/_common/components/pages/schedule.styl
#	source/css/_common/components/post/post-reward.styl
#	source/css/_common/components/sidebar/sidebar.styl
#	source/css/_common/components/tags/note-modern.styl
#	source/css/_common/scaffolding/tables.styl

Signed-off-by: Anthony Yau <antsyau@outlook.com>
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants