Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add some options for quicklink #625

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Refactor: Add some options for quicklink #625

merged 1 commit into from
Feb 26, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Feb 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved N/A

What is the new behavior?

Remove hardcode in quicklink.swig, now timeout, priority, ignores can be set up in _config.yml,

  • Screens with this changes:

My server is in Seattle, it seems too bad, please ignore the network delay, which has nothing to do with quicklink.

How to use?

In NexT _config.yml:

...
quicklink:
  enable: true
  timeout: 3000
  priority: true
  ignores:
...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Feb 24, 2019
@ivan-nginx ivan-nginx merged commit 8192255 into theme-next:master Feb 26, 2019
@1v9 1v9 deleted the quicklink branch February 26, 2019 21:35
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants