Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amount option to tagcloud #662

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Amount option to tagcloud #662

merged 3 commits into from
Mar 7, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 7, 2019

tagcloud:
+  amount: 200

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: iissnan/hexo-theme-next#1908

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@@ -43,9 +43,9 @@
</div>
<div class="tag-cloud-tags">
{% if not theme.tagcloud %}
{{ tagcloud({min_font: 12, max_font: 30, amount: 300, color: true, start_color: '#ccc', end_color: '#111'}) }}
{{ tagcloud({min_font: 12, max_font: 30, amount: 200, color: true, start_color: '#ccc', end_color: '#111'}) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default 300 -> 200?

@1v9
Copy link
Member

1v9 commented Mar 7, 2019

😆 why 200 -> 300 -> 200?

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Mar 7, 2019

@1v9 @jiangtj iissnan/hexo-theme-next@de271c1, "Temporary" solution for #1908, so change it back...

@1v9
Copy link
Member

1v9 commented Mar 7, 2019

I think keep it, or add a statement for tagcloud amount, # if your tags more than 200, you should enable this option and change amount value

Hmmm seems no need to add a statement...

@stevenjoezhang
Copy link
Contributor Author

I'll add it to the docs in theme-next.org

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 7, 2019
@stevenjoezhang stevenjoezhang merged commit 71d5980 into theme-next:master Mar 7, 2019
@stevenjoezhang stevenjoezhang deleted the tagcloud branch March 7, 2019 05:33
@ivan-nginx ivan-nginx changed the title Fix #1908: Tags amount Added Tags amount option Mar 7, 2019
1v9 added a commit that referenced this pull request Mar 7, 2019
@liolok liolok changed the title Added Tags amount option Add amount option to tagcloud Mar 31, 2019
@liolok liolok changed the title Add amount option to tagcloud Amount option to tagcloud Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

标签云显示不完整
3 participants