Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stylesheets from .swig to .styl files #680

Merged
merged 7 commits into from
Mar 12, 2019
Merged

Move stylesheets from .swig to .styl files #680

merged 7 commits into from
Mar 12, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Mar 12, 2019

nice work, but you changed something in base.styl, test is boring 🤔, is there any screenshot to show the difference?

@stevenjoezhang
Copy link
Contributor Author

Theoretically, there is no change, they are equivalent expressions. 🤔

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 12, 2019
@stevenjoezhang stevenjoezhang merged commit dafb5bf into theme-next:master Mar 12, 2019
@stevenjoezhang stevenjoezhang deleted the optimize branch March 12, 2019 12:45
@ivan-nginx ivan-nginx changed the title Move stylesheets in .swig to .styl Moved stylesheets from .swig to .styl files Mar 17, 2019
@liolok liolok changed the title Moved stylesheets from .swig to .styl files Move stylesheets from .swig to .styl files Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Move stylesheets in .swig to .styl (theme-next#680)
7616fa4
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
@renovate
Update dependency c8 to v8.0.1 (theme-next#680)
e5026ed 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

Assignees
No one assigned
Labels
🛠 Improvement
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @1v9 @ivan-nginx