Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md, remove unused URLs #727

Merged
merged 6 commits into from
Mar 23, 2019
Merged

Update README.md, remove unused URLs #727

merged 6 commits into from
Mar 23, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 23, 2019 •
edited
Loading

Changes:

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 23, 2019
ivan-nginx
ivan-nginx requested changes Mar 23, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait...

ivan-nginx
ivan-nginx requested changes Mar 23, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to uncomment badges, they stay there as backup.
No need to switch places badges, it's just variables and don't affect anything.
Also, readme's soon will be strongly refactored. Almost all links with docs must be targeted on site.

Rolling back unneded changes. Thank's.

@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx https://blog.zzbd.org is not accessible now.
feature-request was renamed to %22Feature+Request%22

@1v9
Copy link
Member

1v9 commented Mar 23, 2019

@stevenjoezhang His certificate has expired but site is available.

@ivan-nginx
Copy link
Member

@ivan-nginx https://blog.zzbd.org is not accessible now.
feature-request was renamed to %22Feature+Request%22

Yep, only this 2 changes enough.

@stevenjoezhang
Copy link
Contributor Author

@1v9 Seems it was redirected to this: https://dnspod.qcloud.com/static/block.html?d=blog.zzbd.org

@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx OK, I'll revert some changes

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 23, 2019 •
edited
Loading

@stevenjoezhang also, u can do like me: create local branch and then push this your local branch to remote repo, to this repo (coz u have Admin rights, all members they have) and after that create pull-request from this branch to main master. It will be able to change branch here and see live preview before pull merged.

Example: https://github.com/theme-next/hexo-theme-next/blob/security-section/docs/zh-CN/CONTRIBUTING.md

See the difference:
image

image

@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx Thanks, this is a better solution 👍

@ivan-nginx ivan-nginx merged commit 9f23604 into theme-next:master Mar 23, 2019
@ivan-nginx ivan-nginx deleted the docs branch March 23, 2019 17:12
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang @ivan-nginx
Update README.md, remove unused URLs (theme-next#727)
cb597a2 
* Update README

* Delete link

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx ivan-nginx approved these changes

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
📖 Docs
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @1v9 @ivan-nginx