Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Pictures layout #931

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Group Pictures layout #931

merged 2 commits into from
Jul 3, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Jun 25, 2019 •
edited by stevenjoezhang
Loading

Related issues: #713 #929.
Current layouts of GP in page and post are different and wrong.

@1v9 1v9 added this to the v7.2.0 milestone Jun 25, 2019
@1v9 1v9 marked this pull request as ready for review June 25, 2019 13:02
@1v9
Copy link
Member Author

1v9 commented Jun 25, 2019

Found some other layout broken in different schemes, it's a disaster...

@1v9 1v9 removed this from the v7.2.0 milestone Jun 26, 2019
@1v9
Copy link
Member Author

1v9 commented Jun 26, 2019 •
edited
Loading

As I wrote above, I only modified minor styles, but the layouts in different schemes, including page and post, have a lot of weird CSS problems that are beyond my ability. This does not even involve the potential js part we talked before. 😅

Insert layout: post into the front-matter of the page containing the group pictures through some hexo filter?

Suddenly everything is ok and IDK why 😅

@khoint0210
Copy link

This work like a charm merges it plzzz... 😢

@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 3, 2019
@stevenjoezhang stevenjoezhang merged commit ae8501b into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the GP branch July 3, 2019 03:39
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 3, 2019
Closed
@1v9 1v9 changed the title Fix Group Pictures layout Group Pictures layout Jul 4, 2019
@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Jul 12, 2019 •
edited
Loading

iissnan/hexo-theme-next#295 (comment)

其实iissnan的原始设计就是这样，grouppicture只在index page有效，在点进去之后就是每行一张图片的样式
当然这个PR也没有问题，只是grouppicture必须配合fancybox或者medium zoom才能达到效果

See also next-theme/hexo-theme-next@fc68fbe

@ivan-nginx ivan-nginx mentioned this pull request Aug 4, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9 @stevenjoezhang
Fix Group Pictures layout (theme-next#931)
1e5dd63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
CSS 🛠 Improvement
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@1v9 @khoint0210 @stevenjoezhang