Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable selection for highlight meta #977

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Disable selection for highlight meta #977

merged 1 commit into from
Jul 17, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #448

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Jul 17, 2019

And codeblock.copy_button still copy meta, maybe add an option or do something like refactoring dimmer by you before --- don't give choice to users 😉

@stevenjoezhang stevenjoezhang merged commit 183e5b1 into master Jul 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the select branch July 17, 2019 08:25
@ivan-nginx ivan-nginx mentioned this pull request Aug 4, 2019
33 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Copy link
Contributor Author

Relevant issue #1110

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented May 8, 2020

Reverted in next-theme/hexo-theme-next@9fdaba2

markdownlint recommends that don't use dollar signs before commands without showing output.

https://github.com/DavidAnson/markdownlint/blob/main/doc/md014.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable selection for Dollar signs in Markdown code blocks
2 participants