Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme: Sidebar component #143

Closed
rluders opened this issue May 17, 2022 · 0 comments · Fixed by #200
Closed

Theme: Sidebar component #143

rluders opened this issue May 17, 2022 · 0 comments · Fixed by #200
Assignees
@tulup-conner
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request

Comments

@rluders
Copy link
Collaborator

rluders commented May 17, 2022

Is your feature request related to a problem? Please describe.
Improve the theme support to the component (and subcomponents).

Describe the solution you'd like

  • All default styles must be moved to the default theme;

Describe alternatives you've considered
n/a

Additional context
n/a
@rluders rluders added 🚀 enhancement New feature or request good first issue Good for newcomers labels May 17, 2022
@mouracamila mouracamila self-assigned this May 29, 2022
@rluders rluders added this to the v1.0.0-alpha milestone Jun 2, 2022
@rluders rluders moved this from Backlog to In Progress in Flowbite React Development Jun 2, 2022
@rluders rluders moved this from In Progress to Todo in Flowbite React Development Jun 2, 2022
@mouracamila mouracamila removed their assignment Jun 5, 2022
@tulup-conner tulup-conner self-assigned this Jun 6, 2022
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jun 6, 2022
@tulup-conner
feat(component): Use FlowbiteTheme in Sidebars, resolves themesbe…
b500c7d 
…rg#143
@tulup-conner tulup-conner mentioned this issue Jun 6, 2022
Merged
3 tasks
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jun 6, 2022
@tulup-conner
feat(component): Use FlowbiteTheme in Sidebars, resolves themesbe…
354616b 
…rg#143
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jun 6, 2022
@tulup-conner
feat(component): Use FlowbiteTheme in Sidebars, resolves themesbe…
caccdb3 
…rg#143
@rluders rluders linked a pull request Jun 8, 2022 that will close this issue
feat(component): Use FlowbiteTheme in Sidebars, resolves #143 #200
Merged
3 tasks
@rluders rluders moved this from Todo to In Progress in Flowbite React Development Jun 8, 2022
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jun 8, 2022
@tulup-conner
feat(component): Use FlowbiteTheme in Sidebars, resolves themesbe…
819843f 
…rg#143
rluders pushed a commit that referenced this issue Jun 8, 2022
@tulup-conner
feat(component): Use FlowbiteTheme in Sidebars, resolves #143 (#200)
59654eb 
* feat(type): Add `Sidebar` to `FlowbiteTheme`

```js
sidebar: {
    base: string;
    collapsed: FlowbiteBoolean;
    inner: string;
    collapse: {
      button: string;
      icon: {
        base: string;
        open: FlowbiteBoolean;
      };
      label: {
        base: string;
        icon: string;
      };
      list: string;
    };
    cta: {
      base: string;
      color: SidebarCTAColors;
    };
    item: {
      active: FlowbiteBoolean;
      base: string;
      collapsed: {
        insideCollapse: string;
      };
      content: {
        base: string;
        collapsed: string;
      };
      icon: {
        base: string;
        active: string;
      };
    };
    items: string;
    itemGroup: string;
    logo: {
      base: string;
      collapsed: FlowbiteBoolean;
      img: string;
    };
  };
```

* feat(component): Use `FlowbiteTheme` in `Sidebar`s, resolves #143

* test(component): Add theme unit tests for `Sidebar`s

* fix(docs): Remove `import flowbite` from docs

This is deprecated behavior.

* fix(docs): Add `Sidebar` theme for docs examples

The `Sidebar` examples need a non-standard background
color.
Repository owner moved this from In Progress to Done in Flowbite React Development Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tulup-conner tulup-conner

Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Projects
Flowbite React Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(component): Use FlowbiteTheme in Sidebars, resolves #143 tulup-conner/flowbite-react
3 participants
@rluders @mouracamila @tulup-conner