Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Sidebar page #53

Closed
mouracamila opened this issue Apr 18, 2022 · 1 comment · Fixed by #69
Closed

Create Sidebar page #53

mouracamila opened this issue Apr 18, 2022 · 1 comment · Fixed by #69
Assignees
@tulup-conner
Labels
📚 documentation Improvements or additions to documentation 🚀 enhancement New feature or request

Comments

@mouracamila
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The sidebar page missing in the documentation

Describe the solution you'd like
Implement the Sidebar page

Describe alternatives you've considered
n/a

Additional context
n/a
@mouracamila mouracamila added 📚 documentation Improvements or additions to documentation 🚀 enhancement New feature or request labels Apr 18, 2022
@tulup-conner
Copy link
Collaborator

I'll take this

@tulup-conner tulup-conner mentioned this issue May 1, 2022
Merged
5 tasks
bacali95 pushed a commit that referenced this issue May 2, 2022
@tulup-conner
feat(route): Add Sidebar examples page & stories, resolving #53 #56 (…
38b86bd 
…#69)

* feat(route): Add `Sidebar` examples with new API

Adds the following examples for `Sidebar`s:

- [x] Default sidebar
- [x] Multi-level dropdown
- [x] Content separator
- [x] CTA button
- [x] Logo branding

* test(component): Add stories for `Sidebar`, resolving #56

The `Sidebar` is not highly configurable at the root
component, but there are a number of ways to set up
the contents, so we added those examples.

* refactor(story): Fix dupe story name in `Sidebar`

* fix(route): Restore accurate `Sidebar` example markup

Creating a component to reuse the code between
`storybook` and the page caused the page to display
the shortcut component instead of the actual
component's code.

* refactor(route): Use `flowbite-react` components in `Sidebar` example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tulup-conner tulup-conner

Labels
📚 documentation Improvements or additions to documentation 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(route): Add Sidebar examples page & stories, resolving #53 #56 tulup-conner/flowbite-react
2 participants
@mouracamila @tulup-conner