Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(popover) - fix svg path JSX format #1372

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

SutuSebastian
Copy link
Collaborator

@SutuSebastian SutuSebastian commented Apr 17, 2024

Changes

  • fix svg path JSX format
  • fix warnings in console

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 6a785c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 9:24am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 9:24am

Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Walkthrough

The recent updates focus on standardizing attribute names in SVG elements within React components. Specifically, attributes related to stroke properties in SVGs have been renamed to match React's camelCase convention, enhancing code consistency and readability.

Changes

Files Changes Summary
.../popover/popover.image.tsx,
.../popover/popover.password.tsx
Updated SVG attribute names to camelCase: strokeLinecap, strokeLinejoin, strokeWidth.

🐇🌟
Oh hark, dear code, so sleek, so fine,
With strokes so neat in every line.
From dash to curve, all smoothly blend,
In camelCase, our new best friend.
Hop, skip, a leap in code's ballet,
A rabbit's cheer for the update day!
🌟🐇


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8ae8b16 and 6a785c7.
Files selected for processing (2)
  • apps/web/examples/popover/popover.image.tsx (2 hunks)
  • apps/web/examples/popover/popover.password.tsx (6 hunks)
Additional comments not posted (5)
apps/web/examples/popover/popover.image.tsx (2)

37-39: Correct use of JSX attribute naming conventions for SVG elements.


98-100: Correct use of JSX attribute naming conventions for SVG elements.

apps/web/examples/popover/popover.password.tsx (3)

47-49: Correct use of JSX attribute naming conventions for SVG elements.


65-67: Correct use of JSX attribute naming conventions for SVG elements.


83-85: Correct use of JSX attribute naming conventions for SVG elements.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SutuSebastian SutuSebastian merged commit e76c506 into main Apr 17, 2024
8 checks passed
@SutuSebastian SutuSebastian deleted the cleanup/popover branch April 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant