Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Toggle Switch - styles #1428

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

SutuSebastian
Copy link
Collaborator

@SutuSebastian SutuSebastian commented Jun 20, 2024

Changes

  • RTL
  • broken switch when label too long
  • bring back animations

Issues

#587, #884, #1360

Result

Before

Screen.Recording.2024-06-20.at.11.39.32.mov

After

Screen.Recording.2024-06-20.at.11.38.42.mov

Summary by CodeRabbit

  • Bug Fixes

    • Fixed issues with Toggle Switch styles in RTL layouts.
    • Resolved problems with broken switches when labels are too long.
    • Restored animations for Toggle Switch interactions.
  • Style

    • Updated alignment and positioning of Toggle Switch elements for consistent appearance.
    • Adjusted sizes and dimensions for small, medium, and large variants.

- RTL
- broken switch when label too long
- bring back animations
- text align start
@SutuSebastian SutuSebastian added 🐛 bug Something isn't working 📚 documentation Improvements or additions to documentation labels Jun 20, 2024
@SutuSebastian SutuSebastian self-assigned this Jun 20, 2024
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 2a77be5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
flowbite-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:48am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:48am

Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Walkthrough

The recent updates focus on enhancing the ToggleSwitch component's styling and functionality across various files. Key changes include modifying CSS alignments and styles, improving right-to-left (RTL) support, and fixing label-related issues. The adjustments ensure better visual consistency and usability while restoring smooth animations.

Changes

File(s) Summary
.../forms/forms.toggleSwitch.tsx Updated container CSS class to align items at the start instead of the center within a React component
.../src/components/ToggleSwitch/theme.ts Modified base styles, label positioning, appearance, and sizes of the ToggleSwitch component

Poem

In the fields where toggles gleam,
We've fine-tuned switches, quite a dream.
Aligned to start, no more the center,
Labels neat, animations enter.
With styles transformed, and sizes right,
Our UI's set to beam so bright! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92f41fe and 65a15ae.

Files selected for processing (2)
  • apps/web/examples/forms/forms.toggleSwitch.tsx (2 hunks)
  • packages/ui/src/components/ToggleSwitch/theme.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • apps/web/examples/forms/forms.toggleSwitch.tsx
Additional comments not posted (3)
packages/ui/src/components/ToggleSwitch/theme.ts (3)

6-6: Changes enhance accessibility and UI consistency, particularly for RTL support.

Also applies to: 11-11


14-16: Enhanced transition effects and RTL support align well with PR objectives.


39-41: Updated size configurations enhance responsiveness and usability.
[APPROved]

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 65a15ae and 2a77be5.

Files selected for processing (1)
  • .changeset/seven-carrots-report.md (1 hunks)
Additional comments not posted (1)
.changeset/seven-carrots-report.md (1)

1-9: Looks good! This changeset clearly describes the fixes and enhancements made to the Toggle Switch component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant