-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Toggle Switch - styles #1428
Conversation
- RTL - broken switch when label too long - bring back animations
- text align start
🦋 Changeset detectedLatest commit: 2a77be5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe recent updates focus on enhancing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/web/examples/forms/forms.toggleSwitch.tsx (2 hunks)
- packages/ui/src/components/ToggleSwitch/theme.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- apps/web/examples/forms/forms.toggleSwitch.tsx
Additional comments not posted (3)
packages/ui/src/components/ToggleSwitch/theme.ts (3)
6-6
: Changes enhance accessibility and UI consistency, particularly for RTL support.Also applies to: 11-11
14-16
: Enhanced transition effects and RTL support align well with PR objectives.
39-41
: Updated size configurations enhance responsiveness and usability.
[APPROved]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .changeset/seven-carrots-report.md (1 hunks)
Additional comments not posted (1)
.changeset/seven-carrots-report.md (1)
1-9
: Looks good! This changeset clearly describes the fixes and enhancements made to the Toggle Switch component.
Changes
Issues
#587, #884, #1360
Result
Before
Screen.Recording.2024-06-20.at.11.39.32.mov
After
Screen.Recording.2024-06-20.at.11.38.42.mov
Summary by CodeRabbit
Bug Fixes
Style