-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not allowing to select other year #1465
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe recent changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/ui/src/components/Datepicker/Views/Months.tsx (2 hunks)
Additional comments not posted (2)
packages/ui/src/components/Datepicker/Views/Months.tsx (2)
23-32
: LGTM! EnsureviewDate
is correctly handled.The addition of
viewDate
in the destructuring assignment fromuseDatePickerContext
is correct. This change ensures that the component references the current view date directly.
42-42
: LGTM! Ensure the logic modification is correct.The modification to set the year of
newDate
to match the year ofviewDate
is correct. This change ensures that the selected month aligns with the current view date.
This fixes a bug introduced by #1457 not being able to select any other year except for 2024.
Related issues #1456
Summary by CodeRabbit
Datepicker
component for improved date selection accuracy.Datepicker
to ensure consistency in year selection.