-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Make label prop optional in Dropdown component #1468
chore: Make label prop optional in Dropdown component #1468
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe recent modification to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/ui/src/components/Dropdown/Dropdown.tsx (1 hunks)
Additional comments not posted (2)
packages/ui/src/components/Dropdown/Dropdown.tsx (2)
48-48
: Change approved:label
is now optional.The
label
property in theDropdownProps
interface is now optional, which aligns with the PR's objective to enhance flexibility. Ensure that the component handles cases where the label is not provided, particularly in rendering and accessibility.
Line range hint
87-137
:
Verify component behavior withoutlabel
.The
DropdownComponent
uses thelabel
prop within theTrigger
component. Ensure that the component renders correctly and maintains accessibility when thelabel
is not provided. Consider adding default content or handling the absence of a label explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why vercel is failing, but it is happening in other PRs as well. The code looks good to me, thanks @raky291
silly cache. |
Summarize the changes made and the motivation behind them.
Reference related issues using
#
followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.
#1466
Summary by CodeRabbit
New Features
label
property in the Dropdown component is now optional, enhancing flexibility for developers when using the component.Bug Fixes