Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ Added props to change Previous and Next text on Pagination. #358

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

tiagossa1
Copy link
Contributor

  • Added test for changing pagination text.
  • Added an example on how change default Pagination text.

Description

In this PR, I've added a new feature to change default Previous and Next text in the Pagination component. This was made possible by creating two new optional props called previousText and nextText.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

None.

How Has This Been Tested?

I've ran the example pages and created an unit test exclusively for this new feature.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

+ Added test for changing pagination text.
+ Added an example on how change default Pagination text.
@rluders rluders linked an issue Sep 19, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 98.61% // Head: 98.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (94f0b24) compared to base (36f085b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          89       89           
  Lines        4112     4116    +4     
  Branches      375      375           
=======================================
+ Hits         4055     4059    +4     
  Misses         57       57           
Impacted Files Coverage Δ
src/lib/components/Pagination/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rluders rluders merged commit eaa7d6c into themesberg:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Pagination Text
2 participants