Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's have a choice of colors for the ToggleSwitch component #407

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

CYB3RL1F3
Copy link
Contributor

ToggleSwitch component color choice

This PR includes the possibility to choose the color of the ToggleSwitch component, not only blue.
Information : I chose some colors, my personal need was for success, gray and yellow one. I'm open to feedback concerning the choose of colors. Btw the component is also open to classNames.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Storybook
  • Integration on my personal apps

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 98.47% // Head: 98.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1cc6137) compared to base (efc0156).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   98.47%   98.48%           
=======================================
  Files         102      102           
  Lines        4264     4292   +28     
  Branches      388      388           
=======================================
+ Hits         4199     4227   +28     
  Misses         65       65           
Impacted Files Coverage Δ
...ponents/FormControls/ToggleSwitch/ToggleSwitch.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders
Copy link
Collaborator

rluders commented Oct 23, 2022

I'm asking myself if we do have this option at the https://flowbite.com? Normally all the implementations reproduces the standard library. In this case we also want to ask @zoltanszogyenyi about it.

@CYB3RL1F3
Copy link
Contributor Author

I guess I have the response on flowbite's website ^^'

screenshot

Maybe I put "too much colors" but I think btw we should standardize colors, because it doesn't make sense imo to have "success" "failure" etc in a side, and "red", "blue", "green" in another side. Actually I set up all colors available.

@rluders rluders merged commit 1fd1d61 into themesberg:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants