refactor(toggleswitch.tsx): toggleSwitch optional props #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToggleSwitch optional props themesberg#925
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
- Coverage 99.54% 99.51% -0.04%
==========================================
Files 163 167 +4
Lines 6621 6942 +321
Branches 401 421 +20
==========================================
+ Hits 6591 6908 +317
- Misses 30 34 +4
☔ View full report in Codecov by Sentry. |
tulup-conner
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Thank you for taking this issue on! I know we have tons of existing code where we do this, but we would like to change the pattern of
{booleanCondition && <SomeJSX />}
to
{booleanCondition ? <SomeJSX /> : null}
The first example will cause a 0 to appear if the condition is false.
Also, if you could add an example to the docs for <ToggleSwitch> where the label is omitted, that would be greatly appreciated.
|
Okay! I'll make the changes asap |
improved quality of code
rluders
approved these changes
Sep 21, 2023
maman
pushed a commit
to transkripid/flowbite-react
that referenced
this pull request
Oct 7, 2023
* refactor(toggleswitch.tsx): toggleSwitch optional props ToggleSwitch optional props themesberg#925 * refactor(better sintax): improved quality of code improved quality of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToggleSwitch optional props
#925