-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HTML attribute: accept in FwbFileInput #278
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, Thank You!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gitamgadtaula I've just noticed... there is another input
field on line 49... please add it there as well.
Added :accept="accept" in the other file input.
@Sqrcz Oh how could I have missed that one too. Anyway I added it and should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thank you!
The input file type component was missing native html attribute accept so in this commit i have included that. So now the users can use it something like
<fwb-file-input v-model="file" label="Upload file" accept="video/*" />