Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTML attribute: accept in FwbFileInput #278

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

gitamgadtaula
Copy link
Contributor

The input file type component was missing native html attribute accept so in this commit i have included that. So now the users can use it something like <fwb-file-input v-model="file" label="Upload file" accept="video/*" />

Copy link

stackblitz bot commented Mar 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for sensational-seahorse-8635f8 ready!

Name Link
🔨 Latest commit 911f1b9
🔍 Latest deploy log https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/662c5f6beab7530008b22a00
😎 Deploy Preview https://deploy-preview-278--sensational-seahorse-8635f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Sqrcz Sqrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, Thank You!

Copy link
Collaborator

@Sqrcz Sqrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gitamgadtaula I've just noticed... there is another input field on line 49... please add it there as well.

Added  :accept="accept" in the other file input.
@gitamgadtaula
Copy link
Contributor Author

@Sqrcz Oh how could I have missed that one too. Anyway I added it and should be good to go now.

Copy link
Contributor

@Tomek-N Tomek-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@Sqrcz Sqrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thank you!

@Sqrcz Sqrcz merged commit d2b984a into themesberg:main Apr 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants