Fix bug preventing custom args from being passed to custom controls #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referent to #1425
The problem here lies on the fact that
get_class_varsonly gets the default class vars, not the ones that are set later by doing$this->var = .... On the other handget_object_varsget's the defined vars on the current instance.As I mentioned on the issue, I am no PHP/WP specialist, so I may not be aware of other implications this change might have, feel free to ignore this PR and fix it yourself or just let me know something I else I might have to take care.
Also, I have to say, thanks for this plugin, it's really neat 👍 ..It's saving me a lot of time