Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow inflection rule chains with "polite" #627

Merged
merged 14 commits into from
Feb 4, 2024

Conversation

StefanVukovic99
Copy link
Member

-まして forms weren't working, the rest are refactored to match.

(also interested to see what the performance benchmark says)

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner February 3, 2024 13:33
Copy link

codspeed-hq bot commented Feb 3, 2024

CodSpeed Performance Report

Merging #627 will not alter performance

Comparing StefanVukovic99:fix-polite-te (71b8e8b) with master (f7da8a9)

Summary

✅ 1 untouched benchmarks

Copy link

github-actions bot commented Feb 3, 2024

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@toasted-nutbread
Copy link

Oh that's a pretty nice semi-unintentional side effect of the deinflection file format restructure that this was possible so easily and also intelligibly.

@djahandarie djahandarie added this pull request to the merge queue Feb 4, 2024
Merged via the queue into themoeway:master with commit 6b327e0 Feb 4, 2024
7 checks passed
@djahandarie djahandarie added the kind/bug The issue or PR is regarding a bug label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants