Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow portion of overlay does not expand when window is resized. Works correctly in vanilla Lightbox2. #15

Closed
jasonburrows opened this issue Jun 14, 2017 · 3 comments
Labels

Comments

@jasonburrows
Copy link

Hi -

If you use this angular module, once the image loads in the lightbox, if you expand the window the shadow overlay moves to the right and does not expand to overlay the newly exposed portion of the window. This problem does not happen in the 'real' Lightbox2 implementation.

You can see this using your own demo.

Navigate to your demo. Click on an image to bring up the lightbox. Expand the window horizontally. You will see that the shaded overlay does not expand to fill the window.

Now navigate to the "real" lightbox2 implementation here.

Click on one of their sample images. Expand the window horizontally. You will see that the shadow overlay expands to take up the newly exposed screen real estate.

@themyth92
Copy link
Owner

themyth92 commented Jun 15, 2017

Tks for reporting. I will give it a look and fix asap.

@themyth92 themyth92 added the bug label Jun 15, 2017
themyth92 added a commit that referenced this issue Jun 15, 2017
themyth92 added a commit that referenced this issue Jun 15, 2017
@themyth92
Copy link
Owner

It has been fixed, please pull version 1.1.4 on npm

@jasonburrows
Copy link
Author

Works great - thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants