-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular v5 integration #38
Comments
Ah yeah, this issue has been reported here #30. But I will try to update the doc for angular 5. |
IMHO, it shouldn't be necessary to edit the tsconfig.js. I guess that's related to #35. |
themyth92
added a commit
that referenced
this issue
Jan 17, 2018
themyth92
added a commit
that referenced
this issue
Jan 17, 2018
This should be fixed now ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a great port. The only problem I had was around the documentation, if you follow it to integrate it into angular v5.* you will run into a couple of compile errors. So this isnt really a big issues if you know your way around angular 4+ but if you are newbie to angular and trying to use this port, you might run into some issues. So I suggest you update the documentation for angular 5+. Below is the config I used for angular 5.
In .angular-cli.json: add this line to the styles array "../node_modules/angular2-lightbox/lightbox.css"
then in tsconfig.json, I have this:
{
"compileOnSave": false,
"compilerOptions": {
"outDir": "./dist/out-tsc",
"sourceMap": true,
"declaration": false,
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"target": "es5",
"typeRoots": [
"node_modules/@types"
],
"lib": [
"es2017",
"dom"
]
},
"include": [
"src/**/*",
"node_modules/angular2-lightbox/index.ts"
]
}
And then BAM, it worked like magic. Again this is a great port. Thank you sooooo much, was about to write my own version for angular, so you saved me a lot of time. Great job. thanks.
The text was updated successfully, but these errors were encountered: