Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base64 encoded image download filename #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drewmperkins
Copy link

I was using base64 encoded image strings, and when trying to download the picture, the parsing currently in place does not work.

ex: self hosted - http://example.com/file1.png
filename = file1.png
ex: base64 encoded - data:image/jpg;base64,/9j/....
filename = some characters at the end of the last forward slash.

I propose adding an additional argument to the IAlbum interface called fileName, to allow users to override the default attempt of naming downloaded files.

@themyth92
Copy link
Owner

hi @drewmperkins , can u help to resolve conflict and retest again see if it works for u or not. tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants