-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display PDF document preview in lightbox's iframe #97
base: master
Are you sure you want to change the base?
Conversation
@@ -42,7 +42,7 @@ | |||
}, | |||
"repository": { | |||
"type": "git", | |||
"url": "git+https://github.com/themyth92/ngx-lightbox.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please dont change the name of the package
|
||
public needsIframe(src: string) { | ||
// const sanitizedUrl = this._sanitizer.sanitize(SecurityContext.URL, src); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove this line if it is not needed ?
this.albums.push({ | ||
src: 'demo/img/image5.pdf', | ||
thumb: 'demo/img/image5-thumb.jpg', | ||
iframe: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the iframe options needed ? I dont really understand why it is needed for an image ?
Allow lightbox to show preview of PDF files. PDF's are opened in iframe.