t-J-U-V model #132
Closed
t-J-U-V model #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add CI to PariserParr branch
…amiltonian into giovanni-br-issue-116-fix
Giovanni br issue 116 fix
add comput_u function
RichRick1
requested changes
Jul 11, 2024
moha/hamiltonians.py
Outdated
Comment on lines
716
to
717
| connectivity_ppp: Union[list, np.ndarray], | ||
| connectivity_heisenberg: np.ndarray, |
There was a problem hiding this comment.
I think there is only one type of connectivity that needs to be provided. If connectivity is given as list of tuples, adjacency matrix needs to be build first. Once build, it can be used to populate "Heisenberg" part
|
I'm gonna close this PR for now, since we have equivalent PR on the PariserParr branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of implementation of t-J-U-V model