Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Make lincint wrapper more flexible #178

Closed
FarnazH opened this issue Apr 30, 2024 · 6 comments · Fixed by #179
Closed

[REQUEST] Make lincint wrapper more flexible #178

FarnazH opened this issue Apr 30, 2024 · 6 comments · Fixed by #179
Assignees
Labels
enhancement New feature or request

Comments

@FarnazH
Copy link
Member

FarnazH commented Apr 30, 2024

Is there a change to the code or algorithm you would like to see?
In the libcint wrapper:

  • Add notation argument to allow for choosing between "chemist" and "physics" when computing electron_repulsion_integral.
  • Add transform argument to all integral methods; make sure to keep arguments in the same order as original code.

These two items can be addressed in separate PRs.

@FarnazH FarnazH added the enhancement New feature or request label Apr 30, 2024
@msricher
Copy link
Contributor

The first one is implemented and is in the code right now.

@leila-pujal
Copy link
Collaborator

Maybe I am totally mistaken because sometimes with the Libcint class some things slip, but for the electron_repulsion here I was expecting and argument to pass what notation to choose so here it is choose based on what is passed. Maybe I am wrong and you can actually pass the argument already. If so, if you could add an example here that would be really helpful. Let me know what you think.

@FarnazH
Copy link
Member Author

FarnazH commented Apr 30, 2024

@msricher, I am confused too, and cannot take a closer look right now. You are right that the notation argument is supported, but it is not accessible when calling the electron_repulsion_integral as @leila-pujal mentioned.

Can you please give an example of how electron repulsion integrals can be computed with "chemists" notation?

@msricher
Copy link
Contributor

Oh, that's right! I forgot to make the argument accessible with the user-facing functions. I will do that. Thank you both.

@leila-pujal
Copy link
Collaborator

No worries! Thanks a lot

@leila-pujal
Copy link
Collaborator

Do you think you can add this to PR #180 ?

leila-pujal added a commit that referenced this issue May 2, 2024
---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: leila-pujal <leila946@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants