Add little things to radial \rho example #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marco-2023
commented
Jan 4, 2024
marco-2023
commented
- The explanation on the angular integration was improved
- The maxima of the radial electron density distribution were found using scipy.
1. The explanation on the angular integration was improved 2. The maxima of the radial electron density distribution were found using scipy.
This API change is described in theochem/gbasis#140
FarnazH
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
In anticipation of theochem/gbasis#140, I updated the API. I have no further comments, so feel free to merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.