-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub action for docs #330
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Reviewer's Guide by SourceryThis pull request introduces a GitHub Action to build and deploy the documentation for IOData using GitHub Pages. It includes significant changes to the Sphinx configuration, documentation structure, and codebase to support this new workflow. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK by me. We started using a lot more JupyterBook for documentation, as that seems sort of seamless (it's what GQCP uses too).
Given the "history" of IOData with Sphinx, though, I think this is a good choice.
Thanks for the suggestion. I'll definitely check out JupyterBook. It seems interesting, but it is indeed quite a bit of work to convert all the documentation. |
For future reference, the documentation can now be found at the following URLs:
|
I've also removed the preview on my tovrstra repository. |
This will build the documentation for IOData in a GitHub Action, using the new GitHub Pages deployment feature. (It no longer requires a
github-pages
branch, so we can remove it after this PR is merged.)Preview on my repo: https://tovrstra.github.io/iodata/index.html
In addition to adding a file
.github/actions.sphinx.yaml
, the following changes were made:conf.py
file was recreated from scratch, by following the Sphinx getting started documentation. Orconf.py
seemed to contain outdated stuff, which was hard to get right.gendocs.sh
is replaced by corresponding code inconf.py
. Thegen_*.py
scripts have been updated accordingly.doc/
todocs/
, which is more common. This makes it easier to borrow snippets from other GitHub projects.I will YOLO-merge this on Friday, June 14 unless reviewed earlier.
See #313 for the bigger picture.
Summary by Sourcery
This pull request introduces a GitHub Action to build and deploy documentation using GitHub Pages, updates the Sphinx configuration and generation scripts, switches the Sphinx theme to Furo, and renames the
doc/
directory todocs/
. It also fixes various code typos, updates class attributes for better documentation, and adds tests for example scripts.gendocs.sh
script with corresponding code inconf.py
.gen_*.py
scripts to align with the new documentation generation process.doc/
directory todocs/
for consistency with common conventions.sphinx.yaml
) to automate the building and deployment of documentation.conf.py
file from scratch to follow the latest Sphinx documentation guidelines.