Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deepsource coverage analysis #338

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 15, 2024

Deepsource expects coverage reports from pull requests that do not have permissions to send pull requests. This isn't very useful. I'll keep it in the workflow file, unless it also leads to complaints in future pull requests.

We'll stick with codecov for now...

I will YOLO-merge this on Friday, June 21, unless reviewed earlier.

Summary by Sourcery

This pull request disables the DeepSource test coverage analyzer due to issues with coverage reports from pull requests lacking necessary permissions. The configuration for the test coverage analyzer has been removed from the .deepsource.toml file.

  • CI:
    • Disabled the DeepSource test coverage analyzer in the configuration file.

Copy link

deepsource-io bot commented Jun 15, 2024

Here's the code health analysis summary for commits d61c2ed..9c12646. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

sourcery-ai bot commented Jun 15, 2024

Reviewer's Guide by Sourcery

This pull request disables the Deepsource coverage analysis by removing the 'test-coverage' analyzer configuration from the .deepsource.toml file. The rationale is that Deepsource expects coverage reports from pull requests that do not have permissions to send them, which is not useful. The team will continue using Codecov for coverage analysis.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible.

@tovrstra
Copy link
Member Author

Thanks for checking.

@tovrstra tovrstra merged commit f4ea3b8 into theochem:main Jun 15, 2024
12 checks passed
@tovrstra tovrstra deleted the no-deepsource-coverage branch June 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants