Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with minimal repo setup guide in .github #343

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 19, 2024

This brings the IOData repo in line with the instructions in theochem/.github#7

See #313 and theochem/.github#5 for more background.

I've added a relatively conservative max file size, but we can still make exceptions if needed. IOData does not use Git LFS, which I'm inclined to keep that way. My experiences so far with Git LFS have not been great.

Summary by Sourcery

This pull request updates the .pre-commit-config.yaml file to align with the minimal repository setup guide, including setting a conservative max file size limit and excluding binary files from CRLF removal.

  • Chores:
    • Updated .pre-commit-config.yaml to align with the minimal repo setup guide, including setting a max file size limit of 100KB for added files and excluding binary files from CRLF removal.

Copy link
Contributor

sourcery-ai bot commented Jun 19, 2024

Reviewer's Guide by Sourcery

This pull request updates the .pre-commit-config.yaml file to align with the minimal repo setup guide. Key changes include setting a max file size limit of 100KB for the 'check-added-large-files' hook, reordering the 'check-yaml' hook, excluding binary files from the 'remove-crlf' hook, and updating the 'ruff-pre-commit' hook version from v0.4.8 to v0.4.9.

File-Level Changes

Files Changes
.pre-commit-config.yaml Updated pre-commit hooks configuration to align with the minimal repo setup guide, including setting a max file size limit, reordering hooks, excluding binary files from certain checks, and updating hook versions.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jun 19, 2024

Here's the code health analysis summary for commits 07421c3..d11a4df. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
tovrstra and others added 2 commits June 19, 2024 11:42
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovrstra
Copy link
Member Author

Thanks for reviewing. Merging...

@tovrstra tovrstra merged commit 3f2e4fc into theochem:main Jun 20, 2024
12 checks passed
@tovrstra tovrstra deleted the consistent-minimal branch June 20, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants