-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with minimal repo setup guide in .github #343
Conversation
Reviewer's Guide by SourceryThis pull request updates the .pre-commit-config.yaml file to align with the minimal repo setup guide. Key changes include setting a max file size limit of 100KB for the 'check-added-large-files' hook, reordering the 'check-yaml' hook, excluding binary files from the 'remove-crlf' hook, and updating the 'ruff-pre-commit' hook version from v0.4.8 to v0.4.9. File-Level Changes
Tips
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for reviewing. Merging... |
This brings the IOData repo in line with the instructions in theochem/.github#7
See #313 and theochem/.github#5 for more background.
I've added a relatively conservative max file size, but we can still make exceptions if needed. IOData does not use Git LFS, which I'm inclined to keep that way. My experiences so far with Git LFS have not been great.
Summary by Sourcery
This pull request updates the .pre-commit-config.yaml file to align with the minimal repository setup guide, including setting a conservative max file size limit and excluding binary files from CRLF removal.