-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify physicists' versus chemists' notation conventions #364
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #362 by clarifying the use of physicists' versus chemists' notation conventions across multiple files. It corrects terminology in comments and docstrings, adds notes to clarify notation conventions, and improves docstring generation by conditionally including 'Notes' sections. File-Level Changes
Tips
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @tovrstra
Thanks for checking! |
This may help for issue #362. (If it doesn't, improving clarity never hurts.)
I've tried fixing related typos, and also fixed a minor in the docstring code: it now only adds a "Notes" section when there are notes.
Summary by Sourcery
This pull request standardizes the terminology from 'physicist's notation' to 'physicists' notation' across multiple files for consistency and improves the clarity of documentation by conditionally adding a 'Notes' section.