-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typecheck: TextIOBase instead of TextIO #368
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Reviewer's Guide by SourceryThis pull request addresses a type checking issue by replacing File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 4 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for checking, Paul! |
This fixes one aspect of #367, includes test.
As far as I understand, type hints should still use
TextIO
from the typing module, so I'm not changing these.Summary by Sourcery
This pull request fixes a type checking issue by replacing
TextIO
withTextIOBase
in the_interpret_file_lineno
function and adds a new test to verify the handling of mixed pure Cartesian data.TextIO
withTextIOBase
in the_interpret_file_lineno
function.test_mixed_pure_cartesian
to verify the handling of mixed pure Cartesian data in themolden_dump_one
function.