Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

Misc update #55

Merged
merged 6 commits into from
Mar 26, 2020
Merged

Misc update #55

merged 6 commits into from
Mar 26, 2020

Conversation

theofidry
Copy link
Owner

@theofidry theofidry commented Mar 26, 2020 •
edited
Loading

  • Fix some CS
  • Add types
  • Copy the necessary test container services from test.xml instead of prepending the framework bundle test config
  • Make psysh.shell private
  • Inject the Psysh application instead of application child class
  • Add a few missing @private tags

@theofidry
Copy link
Owner Author

@maxhelias would you mind checking this one? Seems to be working fine locally but I may have missed something

maxhelias
maxhelias reviewed Mar 26, 2020
View reviewed changes
Copy link

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small feedback

src/Command/PsyshCommand.php Outdated Show resolved Hide resolved
src/DependencyInjection/PsyshExtension.php Outdated Show resolved Hide resolved
src/DependencyInjection/PsyshExtension.php Show resolved Hide resolved
resources/config/services.xml Show resolved Hide resolved
@theofidry theofidry merged commit 2dc4446 into master Mar 26, 2020
@theofidry theofidry deleted the misc branch March 26, 2020 20:01
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxhelias maxhelias maxhelias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theofidry @maxhelias