fix: various fetch issues #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP method is being set to undefined when a request doesn't provide a method. Check that the property exists before attempting to set it.
Fetch requests can sometimes be passed an entire Request object, handle that scenario.
As per the standard.
|
Thanks for this @ericlewis I'll take a look |
theolampert
reviewed
Apr 4, 2024
There was a problem hiding this comment.
@ericlewis Looks good thank you, I only had one comment.
Would you also be able to let me know what issues you ran into so I can add those to the header and fetch tests?
| let headersClass: @convention(block) () -> Headers = { | ||
| Headers() | ||
| let headersClass: @convention(block) (JSValue?) -> Headers = { headers in | ||
| if let headers { |
There was a problem hiding this comment.
I think you'll also need to check if the underlying JSValue is also null or undefined here, there's a helper for this. Something like:
if let headers, headers.hasValue {There was a problem hiding this comment.
sorry for not seeing this. did you make the change?
There was a problem hiding this comment.
Yep, all good, thanks again for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to bring fetch more in line with specs & fixes some bugs