Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out generate graphapi files #321

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Dec 14, 2024

  • moves all configs/generate related files to internal/ent/generate and internal/graphapi/generate
  • splits out the generate graph api files into:
internral/graphapi/generated
internal/graphai/models

This should drastically help with compile times when only non-generated files (e.g. resolvers/helpers) are touched in the graphapi package:

(⎈ |default:default)➜  core git:(fix-bulk-upload) ✗  actiongraph top -f compile.json
 54.156s  32.13%  build	github.com/theopenlane/core/internal/graphapi/generated
 26.314s  47.74%  build	github.com/theopenlane/core/internal/ent/generated

Before:

(⎈ |default:default)➜  core git:(renovate/limit-prs) ✗ actiongraph top -f compile.json
 89.864s  26.84%  build	github.com/theopenlane/core/internal/graphapi
 39.065s  38.51%  build	github.com/theopenlane/core/internal/ent/generated

Depends on theopenlane/gqlgen-plugins#46

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade marked this pull request as ready for review December 14, 2024 17:37
@golanglemonade golanglemonade requested a review from a team as a code owner December 14, 2024 17:37
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade enabled auto-merge (squash) December 14, 2024 21:28
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Coverage on New Code (required ≥ 20%)
6.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade merged commit b683f31 into main Dec 14, 2024
15 of 16 checks passed
@golanglemonade golanglemonade deleted the feat-split-generated-graphapi branch December 14, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants