[DEMO][api] add microsoft strategy to auth module #3221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freemvmt
force-pushed
the
api-add-microsoft-sso-strategy
branch
3 times, most recently
from
68860b1
to
8e29203
Compare
freemvmt
force-pushed
the
api-add-microsoft-sso-strategy
branch
4 times, most recently
from
0ad864f
to
36a3921
Compare
freemvmt
force-pushed
the
api-add-microsoft-sso-strategy
branch
2 times, most recently
from
ff25274
to
13f22ed
Compare
freemvmt
changed the title
16 tasks
…ct auth routing fix from #3302
DafyddLlyr
force-pushed
the
api-add-microsoft-sso-strategy
branch
from
d2b8ca8
to
b654e05
Compare
|
Closing this demo pizza now that the real deal is on prod! 🚢 See #3453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letting folks sign into the editor with their Microsoft account is shaping up nicely - the code works on local!
To see this first replace the Microsoft client credentials in
api.planx.uk/modules/auth/strategy/microsoft.ts(see Slack), then dopnpm run upin project root,pnpm startin editor, and click 'Login with Microsoft'.A lot of the effort was actually trawling the Azure docs to understand how the application that you have to set up with them needs to be configured, and then trying to get the
passportjsstrategy to play nicely with that. This was especially true because the 'official' strategy I tried to implement turned out to be deprecated (without replacement!) by Microsoft. Steps for setting up the application as required are documented here.Rather than syndicate it all here I'll just point anyone interested in more detail to my notes in Notion, including various hints re security hardenings observed etc.
Development continuing on #3453.