Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Not applicable constraints styling #3450

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat: Not applicable constraints styling #3450

merged 3 commits into from
Jul 24, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Jul 23, 2024 •
edited
Loading

What does this PR do?

  • Updates constraints accordion to use a secondary button to report non-applicable constraints
  • Creates a theme-level chip style named notApplicableTag
  • Updates styling of non-applicable constraints to use notApplicableTag, rendered conditionally for data reported non-applicable constraints and user-reported non-applicable constraints

Example:
https://3450.planx.pizza/lambeth/check-constraints-on-a-property

A good property with multiple constraints:
SW2 1AH
FLAT A, 102, BRIXTON HILL

Feature flag to enable: window.featureFlags.toggle("OVERRIDE_CONSTRAINTS")

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review July 24, 2024 13:13
@ianjon3s ianjon3s requested a review from a team July 24, 2024 13:43
jessicamcinchak
jessicamcinchak approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again for quick turnaround here !

@ianjon3s ianjon3s merged commit 735f43a into main Jul 24, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/constraints-override-styling branch July 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr left review comments

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianjon3s @jessicamcinchak @DafyddLlyr