Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: require exact match of data field segments for automations #3461

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jul 26, 2024

An experiment!

Comes out of planning constraints testing: with current automations behavior, listed.grade.II incorrectly auto-answers listed.grade.I because each segment uses a "startsWith" match rather than exact.

This one-line change now does what we want in this specific use case, but services team will have to determine if it unexpectedly breaks other areas of the schema !
Screenshot from 2024-07-26 09-57-48

More context here from August https://opensystemslab.slack.com/archives/C04DZ1NBUMR/p1721902632687949?thread_ts=1721219483.725279&cid=C04DZ1NBUMR

The way values match is matching-up-to, the . separator isn't material to that behaviour. value.valueAndThenSome matches to value.value or value.valueAnd etc. the same way that value.value.AndThenSome matches to value.value. So changing to listed.gradeI and listed.gradeII wouldn't change that behaviour, the former would still match to the latter. Counterintuitive to our use of . separators and something to be changed perhaps?

@jessicamcinchak jessicamcinchak added UAT (User Agent Testing) actively being tested before deployment demo Demo environment being used by an external team and removed UAT (User Agent Testing) actively being tested before deployment labels Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Pizza

Deployed 062d7f9 to https://3461.planx.pizza.

Useful links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo Demo environment being used by an external team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant