chore: MapAndLabel tidy ups
#3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Sep 9, 2024
| // Set active index as highest tab after removal, so that when you "add" a new feature the tabs increment correctly | ||
| setActiveIndex((features && features.length - 2) || activeIndex - 1); | ||
| setActiveIndex((features && features.length - 2) || 0); |
There was a problem hiding this comment.
If this is - 1 rather than - 2, then there's a known bug:
- Add three features
- Remove feature 3 - active tab is tab 2
- Remove feature 2 - active tab is NOT tab 1 as expected
One to keep thinking on, still not completely satisfied with this solution !
jessicamcinchak
commented
Sep 9, 2024
| }; | ||
|
|
||
| const addInitialFeaturesToMap = (features: Feature[]) => { | ||
| setFeatures(features); | ||
| // TODO: setActiveIndex ? | ||
| // setActiveIndex(features.length - 1); |
There was a problem hiding this comment.
This looks like the right solution to me, and it does indeed mean the latest tab will be active/open when coming "back", but it unexpectedly make all other tabs un-clickable - so noted in PR description as outstanding bug
DafyddLlyr
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tidy ups & fixes now that all major functionality is merged & open for testing ! Follows on from #3625
Fixes here:
propertiesrequire labels to be stored as strings, but we want to sort them as numbersactiveTabIndexmore consistently managed based on length offeatureswhen adding & removing featuresKnown still-outstanding bugs, to address in followup PRs:
featuresarray)