[#71] Add support for "run once" custom script #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
approved these changes
Apr 12, 2024
bin/pgenv
Outdated
| cat <<EOF | ||
| This is the first time PostgreSQL $v is started, | ||
| executing the \`PGENV_SCRIPT_FIRSTSTART\` script | ||
| $PGENV_SCRIPT_FIRSTSTART" |
There was a problem hiding this comment.
No opening quotation mark here. Should it be this?
Suggested change
| $PGENV_SCRIPT_FIRSTSTART" | |
| "$PGENV_SCRIPT_FIRSTSTART" |
bin/pgenv
Outdated
| @@ -781,7 +781,8 @@ pgenv_configuration_write() { | |||
| pgenv_configuration_write_variable "$CONF" "PGENV_RESTART_OPTIONS" "" 'Restart configuration flags' | |||
|
|
|||
| pgenv_configuration_write_variable "$CONF" "PGENV_SCRIPT_POSTINSTALL" "" 'Script to execute when the build process finishes' | |||
| pgenv_configuration_write_variable "$CONF" "PGENV_SCRIPT_POSTINITDB" "" 'Script to execute when initdb finishes' | |||
| pgenv_configuration_write_variable "$CONF" "PGENV_SCRIPT_POSTINITDB" "" 'Script to execute when initdb finishes (and the server has not started yet)' | |||
| pgenv_configuration_write_variable "$CONF" "PGENV_SCRIPT_FIRSTART" "" 'Script to execute at the very first start of the instance' | |||
There was a problem hiding this comment.
Suggested change
| pgenv_configuration_write_variable "$CONF" "PGENV_SCRIPT_FIRSTART" "" 'Script to execute at the very first start of the instance' | |
| pgenv_configuration_write_variable "$CONF" "PGENV_SCRIPT_FIRSTSTART" "" 'Script to execute at the very first start of the instance' |
There was a problem hiding this comment.
shame on me, I was testing without having noted the configuration file produced did have the misspelled word!
This commit introduces a new configuration parameter `PGENV_SCRIPT_FIRSTSTART` that can be pointed to an executable that is run once and only once at the very first start of the selected instance. Therefore, the usage of this script enables for customization of the instance, like for example adding new users and databases. The changes are made directly into the `pgenv_start_instance` function, that is the entry point to a start action: the function in turns calls `pgenv_initdb` that performs the initialization of the instace. If the initialization is done, a new magic variable `PGENV_INITDB_DONE` is set to `1`, so that `pgenv_start_instance` can then decide to execute the script mentioned above. Therefore, the trick here is to mark a "first start" time as the one that immediatly follows the initdb phase. Documentation updated. Version number bumped. Close theory#71
fluca1978
force-pushed
the
custom_installation_script
branch
from
007cf84 to
8d2c963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new configuration parameter
PGENV_SCRIPT_FIRSTSTARTthat can be pointed to an executable that is run once and only once at the very first start of the selected instance.Therefore, the usage of this script enables for customization of the instance, like for example adding new users and databases.
The changes are made directly into the
pgenv_start_instancefunction, that is the entry point to a start action: the function in turns callspgenv_initdbthat performs the initialization of the instace. If the initialization is done, a new magic variablePGENV_INITDB_DONEis set to1, so thatpgenv_start_instancecan then decide to execute the script mentioned above.Therefore, the trick here is to mark a "first start" time as the one that immediatly follows the initdb phase.
Close #71