-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimenting with refactoring tb #345
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @amkram, I've broken a ton of stuff here to make a very basic proof of concept. Basically the idea is:
I'd be interested to know if this is an approach you started with and discarded, and generally any concerns you have about it |
(at present mutations back to reference show up as their own mutations, but we can filter those out) |
Hey, thanks for getting started on this refactor! Sorry that some of my code is a bit messy. A couple of thoughts:
I might not fully understand how filtering works in Taxonium / the refactor, but right now treenome considers
This would be great, and make things like implementing highlighting a lot easier. I think one reason I avoided doing this was to avoid increasing the polygon count, which had caused me some issues in the past. But navigating the browser seems pretty responsive in the PR demo, so I think we should be good! |
Thanks! I don't think you're missing anything, thanks for explaining everything. The first point may well be an issue when I get the non-zoomed out version in - let's see. Thanks for the context! |
(and it's not messy! definitely not in comparison to everything else in the codebase :) ) |
Another recent initially hacky change to try to use modelMatrix to handle X positioning, rather than doing this on the fly and updating the layer. I think this makes a substantial diff to performance (but is atm cancelled out by my removal of extra filtering, maybe time to add that back). |
No description provided.