Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted contract creation locations #100

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Remove unwanted contract creation locations #100

merged 3 commits into from
Feb 1, 2023

Conversation

moonysolari
Copy link
Member

Removed the following locations from the contract creation menu to match official server behavior:

  • Hokkaido Snow Festival
  • Carpathian Mountains
  • All Freelancer-related locations

@moonysolari moonysolari added the contracts mode Related to contracts mode. label Feb 1, 2023
@moonysolari moonysolari added this to the v6 milestone Feb 1, 2023
@moonysolari moonysolari self-assigned this Feb 1, 2023
RDIL
RDIL requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mamushi is intentional, and this flag should prevent this in the first place.

@moonysolari
Copy link
Member Author

Mamushi contract creation is now allowed.

The flag does not work for Trapped or Snug. Trapped has a resolvable CreateContractId that points to Untouchable. Some Snug locations also have resolvable CreateContractIds . For example, that of LOCATION_SNUG_COASTALTOWN_BINGO's points to World of Tomorrow contract creation.

@moonysolari moonysolari requested a review from RDIL February 1, 2023 18:47
@RDIL
Update destinations.ts
a89a5ea 
Signed-off-by: Reece Dunham <me@rdil.rocks>
@RDIL RDIL merged commit a551d30 into thepeacockproject:v6 Feb 1, 2023
@moonysolari moonysolari deleted the contract-creation branch February 1, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

@AnthonyFuller AnthonyFuller Awaiting requested review from AnthonyFuller

Assignees

@moonysolari moonysolari

Labels
contracts mode Related to contracts mode.
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.
2 participants
@moonysolari @RDIL