Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: season of drop challenges #528

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

suanjiansalt
Copy link
Contributor

@suanjiansalt suanjiansalt commented Oct 31, 2024

Scope

  • Adding Fuel to the Fire
  • True Fan

Test Plan

The challenges complete in game successfully

Checklist

  • I have run Prettier to reformat any changed files
  • I have verified my changes work

Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged once a test plan is added

@suanjiansalt
Copy link
Contributor Author

I'm just not sure how to 'plan' a test for this... of all time.

@RDIL
Copy link
Member

RDIL commented Oct 31, 2024

In this case, a reasonable test plan would just be playing through both challenges to make sure they complete successfully

@suanjiansalt suanjiansalt changed the title Add season of drop challenges feat: season of drop challenges Oct 31, 2024
@RDIL RDIL merged commit 705ad8c into thepeacockproject:master Oct 31, 2024
5 checks passed
@suanjiansalt suanjiansalt deleted the challenge-dropseason branch October 31, 2024 13:33
@suanjiansalt suanjiansalt restored the challenge-dropseason branch November 20, 2024 03:52
AnthonyFuller pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants