-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mission end screens for challenges #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just reply to my comment.
Might be related to #86, as global challenges should also display similar behavior. |
I reckon my thing at some point is going to combine with/replace the missionEnd of scoreHandler as well (instead of acting as a plugin), so most likely, I will just have to grab "unticked" challenges to decide on the amount of XP to grant the user profile. |
Regarding challenges, XP is given AS SOON as they're unlocked. Like, pretty much instantly. No waiting for the end screen, during play. |
That's fine, but I believe the original game will increment your Mastery XP progress bar in the first missionend as if you didn't have them before yet, no? If so, we also need something like an "original XP" before any challenges were applied. Unless we decide to just not do this in Peacock :P |
It adds the XP onto mastery (and your player level) as soon as you complete the challenge, what you're thinking of is the visual part of it, which yes, occurs the first time after you've got that XP. So we'll likely need to have something like we have for ticked challenges which is a store of how much XP we need to show the player. This idea, of course, needs to be developed. |
Signed-off-by: Anthony Fuller <24512050+AnthonyFuller@users.noreply.github.com>
Ticked
field to everyChallengeProgression
object in the player profile.