Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mission end screens for challenges #88

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

moonysolari
Copy link
Member

  • Fixes Duplicate tiles of finished challenges at the end of the mission #12
  • Challenge tiles that got "ticked" on a previous mission end screen will not be ticked in succeeding runs.
  • Challenge tiles that did not get a chance to be "ticked" on a mission end screen will be ticked the next time a player triggers the mission end screen.
  • Adds a Ticked field to every ChallengeProgression object in the player profile.
  • Compatible with previous player profile saves.

@moonysolari moonysolari added the challenges Related to in-game challenges. label Jan 21, 2023
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just reply to my comment.

components/profileHandler.ts Show resolved Hide resolved
@moonysolari
Copy link
Member Author

Might be related to #86, as global challenges should also display similar behavior.

@LennardF1989
Copy link
Member

LennardF1989 commented Jan 22, 2023

Might be related to #86, as global challenges should also display similar behavior.

I reckon my thing at some point is going to combine with/replace the missionEnd of scoreHandler as well (instead of acting as a plugin), so most likely, I will just have to grab "unticked" challenges to decide on the amount of XP to grant the user profile.

@AnthonyFuller
Copy link
Contributor

AnthonyFuller commented Jan 23, 2023

I will just have to grab "unticked" challenges to decide on the amount of XP to grant the user profile.

Regarding challenges, XP is given AS SOON as they're unlocked. Like, pretty much instantly. No waiting for the end screen, during play.

@LennardF1989
Copy link
Member

Regarding challenges, XP is given AS SOON as they're unlocked. Like, pretty much instantly. No waiting for the end screen, during play.

That's fine, but I believe the original game will increment your Mastery XP progress bar in the first missionend as if you didn't have them before yet, no? If so, we also need something like an "original XP" before any challenges were applied. Unless we decide to just not do this in Peacock :P

@AnthonyFuller
Copy link
Contributor

I believe the original game will increment your Mastery XP progress bar in the first missionend as if you didn't have them before yet, no?

It adds the XP onto mastery (and your player level) as soon as you complete the challenge, what you're thinking of is the visual part of it, which yes, occurs the first time after you've got that XP. So we'll likely need to have something like we have for ticked challenges which is a store of how much XP we need to show the player. This idea, of course, needs to be developed.

Signed-off-by: Anthony Fuller <24512050+AnthonyFuller@users.noreply.github.com>
@AnthonyFuller AnthonyFuller requested a review from RDIL January 29, 2023 04:16
@RDIL RDIL merged commit 323419c into thepeacockproject:v6 Jan 29, 2023
@moonysolari moonysolari deleted the missionend-challenges branch January 29, 2023 04:30
@moonysolari moonysolari self-assigned this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenges Related to in-game challenges.
Projects
Development

Successfully merging this pull request may close these issues.

Duplicate tiles of finished challenges at the end of the mission
4 participants