CommonMark spec 0.31 compatibility #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinodell
added
spec compliance
colinodell
force-pushed
the
commonmark-spec-0.31
branch
from
d710631
to
f00425f
Compare
We fix issues with list tightness by using a different strategy: 1. Compare the end and start lines of adjoining elements to check tightness. (This required tweaking the end position of some block types to exclude trailing blank lines.) 2. Delay removal of link reference definitions until the entire document is parsed. See commonmark/commonmark.js@df3ea1e
colinodell
force-pushed
the
commonmark-spec-0.31
branch
from
f00425f
to
7b65f63
Compare
|
BC checks are failing because the values of some constants are changing. These particular constants contain regular expressions used to parse Markdown. Because the constants remain usable for the same purposes, we consider this to not be a BC-break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings our library into compliance with the latest version (0.31) of the CommonMark spec.