-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 compatibility #261
Conversation
Testing via docker
|
You could update the matrix in https://github.com/thephpleague/container/blob/4.x/.github/workflows/test.yml to include PHP 8.4 |
I can't see if the workflow is running, so the second commit is not tested |
@philipobenito ping |
Maybe under group |
Will merge next week, just finishing off some major version work.
Sent from Proton Mail Android
…-------- Original Message --------
On 24/09/2024 14:49, Mark Scherer wrote:
Maybe under group thephpleague there is more than one author available with merge/commit rights?
—
Reply to this email directly, [view it on GitHub](#261 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAP3E2ONM4WRY6Y3GGUJDR3ZYFUYHAVCNFSM6AAAAABLJKMKOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGMZTMMRUGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
PHP 8.4 is now in release candidate phase. Would be good to merge this soon. |
Friendly reminder to @philipobenito to get this merged and released, so that everyone can easily test their packages before 8.4 gets out |
Hi @philipobenito, if you are unable to devote time towards the maintenance of this package kindly give access to someone else who can help you or invite maintainers. |
RFC https://php.watch/rfcs/deprecate-implicitly-nullable-types