Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #261

Merged
merged 2 commits into from
Oct 23, 2024
Merged

PHP 8.4 compatibility #261

merged 2 commits into from
Oct 23, 2024

Conversation

andypost
Copy link
Contributor

@andypost
Copy link
Contributor Author

Testing via docker

$ docker run --rm -v $(pwd):/mnt -w /mnt php:8.4.0alpha2-cli-alpine find . -type f -name '*.php' -exec php -l {} \;

@ADmad
Copy link
Contributor

ADmad commented Jul 25, 2024

You could update the matrix in https://github.com/thephpleague/container/blob/4.x/.github/workflows/test.yml to include PHP 8.4

@andypost
Copy link
Contributor Author

I can't see if the workflow is running, so the second commit is not tested

@ADmad
Copy link
Contributor

ADmad commented Sep 6, 2024

@philipobenito ping

@dereuromark
Copy link

Maybe under group thephpleague there is more than one author available with merge/commit rights?

@philipobenito
Copy link
Member

philipobenito commented Sep 24, 2024 via email

@weitzman
Copy link

PHP 8.4 is now in release candidate phase. Would be good to merge this soon.

@LordSimal
Copy link

Friendly reminder to @philipobenito to get this merged and released, so that everyone can easily test their packages before 8.4 gets out

@ADmad
Copy link
Contributor

ADmad commented Oct 23, 2024

Hi @philipobenito, if you are unable to devote time towards the maintenance of this package kindly give access to someone else who can help you or invite maintainers.

@philipobenito philipobenito merged commit 5a6f1c7 into thephpleague:4.x Oct 23, 2024
1 check failed
@andypost andypost deleted the php84 branch October 23, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants