Improve error message for Period::intersect #33

thephpleague · Apr 11, 2016 · 58cc8fd · 58cc8fd
1 parent 5269872
commit 58cc8fd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -30,4 +30,4 @@ script:
   - composer test
 
 after_script:
- - if [ "$COLLECT_COVERAGE" == "true" ]; then wget https://scrutinizer-ci.com/ocular.phar; && php ocular.phar code-coverage:upload --format=php-clover build/logs/clover.xml; fi
+ - if [ "$COLLECT_COVERAGE" == "true" ]; then wget https://scrutinizer-ci.com/ocular.phar; && php ocular.phar code-coverage:upload --format=php-clover build/clover.xml; fi
diff --git a/phpunit.xml b/phpunit.xml
@@ -28,7 +28,7 @@
         <log type="junit" target="build/report.junit.xml"/>
         <log type="coverage-html" target="build/coverage" charset="UTF-8" yui="true" highlight="true"/>
         <log type="coverage-text" target="build/coverage.txt"/>
-        <log type="coverage-clover" target="build/logs/clover.xml"/>
+        <log type="coverage-clover" target="build/clover.xml"/>
     </logging>
 
 </phpunit>
diff --git a/src/Period.php b/src/Period.php
@@ -827,8 +827,8 @@ public function split($interval)
      */
     public function intersect(Period $period)
     {
-        if ($this->abuts($period)) {
-            throw new LogicException('Both object should not abuts');
+        if (! $this->overlaps($period)) {
+            throw new LogicException('Both object should at least overlaps');
         }
 
         return new static(