Sequence::getTotalTimeStampInterval #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyamsprod
reviewed
Mar 15, 2019
|
Ok, I just noticed there is a bug when you use this method on a Sequence containing more then 1 Period. |
nyamsprod
reviewed
Mar 15, 2019
| @@ -226,7 +226,7 @@ public function getGaps(): self | |||
| */ | |||
| public function getTotalTimestampInterval(): float | |||
There was a problem hiding this comment.
you revert the method name change 😄
There was a problem hiding this comment.
Yes, as I said your name makes sense if you intend the inner time between the boundaries.
However I intend the total sum of timestamp intervals of the contained Periods.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in #78 I think that this method would be useful everytime you need to calculate the total amount of hours in a calendar.