Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence::getTotalTimeStampInterval #79

Merged
merged 5 commits into from
Mar 16, 2019
Merged

Sequence::getTotalTimeStampInterval #79

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8bb86b
Sequence::getTotalTimeStampInterval
Bibendus83 Mar 15, 2019
e759dc1
Update Sequence.php
Bibendus83 Mar 15, 2019
3a67057
method name change
Bibendus83 Mar 15, 2019
b971023
no message
Bibendus83 Mar 15, 2019
d558840
fix exception when using this method on sequences with more then one …
Bibendus83 Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sequence.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ public function getGaps(): self
*/
public function getTotalTimestampInterval(): float
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you revert the method name change 😄

Copy link
Contributor Author

@Bibendus83 Bibendus83 Mar 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as I said your name makes sense if you intend the inner time between the boundaries.
However I intend the total sum of timestamp intervals of the contained Periods.

{
$func = function (int $carry, Period $interval): float {
$func = function (float $carry, Period $interval): float {
return $carry + $interval->getTimestampInterval();
};

Expand Down