Change option name from bus to class

This should help prevent confusion with named command buses like in the old symfony bundle, as well as add better cohesion with the new method option.
thephpleague · Sep 18, 2019 · ebd6707 · ebd6707
1 parent cb356e8
commit ebd6707
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -78,7 +78,7 @@ Instead, you can configure the command bus class to scan for, as well as (option
 parameters:
     tactician:
         bootstrap: handler-mapping-loader.php
-        bus: My\App\CommandBus
+        class: My\App\CommandBus
         method: execute
 ~~~
 

diff --git a/extension.neon b/extension.neon
@@ -1,21 +1,21 @@
 parameters:
     tactician:
-        bus: League\Tactician\CommandBus
+        class: League\Tactician\CommandBus
         method: handle
 
 services:
     -
         class: League\Tactician\PHPStan\TacticianRuleSet
         arguments:
-            commandBusClass: %tactician.bus%
+            commandBusClass: %tactician.class%
             commandBusMethod: %tactician.method%
         tags:
             - phpstan.rules.rule
 
     -
         class: League\Tactician\PHPStan\HandlerReturnTypeExtension
         arguments:
-            commandBusClass: %tactician.bus%
+            commandBusClass: %tactician.class%
             commandBusMethod: %tactician.method%
         tags:
             - phpstan.broker.dynamicMethodReturnTypeExtension

diff --git a/src/TacticianRuleSet.php b/src/TacticianRuleSet.php
@@ -38,8 +38,12 @@ final class TacticianRuleSet implements Rule
      */
     private $commandBusMethod;
 
-    public function __construct(CommandToHandlerMapping $mapping, Broker $broker, string $commandBusClass, string $commandBusMethod)
-    {
+    public function __construct(
+        CommandToHandlerMapping $mapping,
+        Broker $broker,
+        string $commandBusClass,
+        string $commandBusMethod
+    ) {
         $this->mapping = $mapping;
         $this->broker = $broker;
         $this->commandBusClass = $commandBusClass;

diff --git a/tests/phpstan-alternate-class.neon b/tests/phpstan-alternate-class.neon
@@ -4,5 +4,5 @@ includes:
 parameters:
     tactician:
         bootstrap: tests/handler-mapping-loader.php
-        bus: MissingHandlerClassForAlternateBus\DerpBus
+        class: MissingHandlerClassForAlternateBus\DerpBus
         method: execute