Improve PR #161

thephpleague · Feb 29, 2020 · 357556f · 357556f
1 parent 3dd2732
commit 357556f
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/UriTemplate.php b/src/UriTemplate.php
@@ -18,6 +18,7 @@
 use League\Uri\Exceptions\SyntaxError;
 use League\Uri\Exceptions\TemplateCanNotBeExpanded;
 use function array_filter;
+use function array_key_exists;
 use function array_keys;
 use function explode;
 use function gettype;
@@ -402,9 +403,7 @@ private function expandExpression(array $foundExpression): string
         $parts = [];
         /** @var array{name:string, modifier:string, position:string} $variable */
         foreach ($expression['variables'] as $variable) {
-            if (isset($this->variables[$variable['name']])) {
-                $parts[] = $this->expandVariable($variable, $expression['operator'], $joiner, $useQuery);
-            }
+            $parts[] = $this->expandVariable($variable, $expression['operator'], $joiner, $useQuery);
         }
 
         $nullFilter = static function ($value): bool {
@@ -430,7 +429,11 @@ private function expandExpression(array $foundExpression): string
      */
     private function expandVariable(array $variable, string $operator, string $joiner, bool $useQuery): string
     {
-        $value = $this->variables[$variable['name']] ?? '';
+        if (!array_key_exists($variable['name'], $this->variables)) {
+            return '';
+        }
+
+        $value = $this->variables[$variable['name']];
         $arguments = [$value, $variable, $operator];
         $method = 'expandString';
         if (is_array($value)) {